Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ember-simple-auth v5 #276

Merged
merged 1 commit into from
Jun 24, 2023
Merged

Support ember-simple-auth v5 #276

merged 1 commit into from
Jun 24, 2023

Conversation

charlesfries
Copy link
Collaborator

No description provided.

@mikkopaderes
Copy link
Owner

It's a simple change, but I'll try to get up-to-date with v5 simple-auth and see if there's anything more to be changed on this project's side.

If none, then I'm good to merge this and cut a release :)

@mikkopaderes mikkopaderes merged commit aac139f into mikkopaderes:master Jun 24, 2023
@mikkopaderes
Copy link
Owner

Thanks for the PR. This line of code can be removed for 5.x users, but since we'll still support 4.x, we can just keep it.

Probably once we move to a 5.x LTS version of Ember, we can drop support for 4.x of ember-simple-auth.

@charlesfries charlesfries deleted the esa branch May 30, 2024 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants