Keep the selection begin index updated #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah, this makes a lot of sense to me and looks correct. Thanks for the good description! |
alml
pushed a commit
to alml/RmlUi
that referenced
this pull request
Jan 2, 2024
|
This will cause a clipboard copy error in 5.1. Is it possible to integrate the modifications and release a 5.2 version ? I want to use rmlui from vcpkg. |
|
We don't really maintain old releases. If you need this fix, then you could make a patch for the vcpkg port. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selection API, introduced thanks to #419, has a problem retrieving the cursor position if no text is selected. In particular, this is a problem with the
WidgetTextInput::GetSelection()method, which is publicly accessible from classes such asElementFormControlInput.If you select some text, unselect text, and call the method, you will get the previous index, which may no longer be valid.
This pull request aims to address this issue. Constantly updating
selection_begin_indexis safe to do; when we want to work with some selection, we first check whetherselection_lengthis greater than zero. Because of this reason,selection_begin_indexmay have whatever value, and it will not break anything... except for the getter mentioned above.