Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add letter-spacing property to RCSS #429

Merged
merged 9 commits into from
Apr 8, 2023
Merged

Add letter-spacing property to RCSS #429

merged 9 commits into from
Apr 8, 2023

Conversation

igorsegallafa
Copy link
Contributor

Related to #426

image

image

@igorsegallafa igorsegallafa mentioned this pull request Mar 12, 2023
Closed
@mikke89 mikke89 added enhancement New feature or request layout Layout engine issues and enhancements labels Mar 13, 2023
mikke89
mikke89 reviewed Mar 13, 2023
View reviewed changes
Copy link
Owner

@mikke89 mikke89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've figured your way around the code base very well. Most of my comments are relatively minor fixups.

Could you add a VisualTest as well? Something that shows the output with different letter-spacing. Maybe something with line-breaks or other edge-cases too?
To get started, you could base the test on another test, such as Tests/Data/VisualTests/word_break.rml.

Just an FYI for the future, you can change the base branch of PRs on GitHub itself. There shouldn't be a need to open new PRs, no worries though.

Source/Core/StyleSheetSpecification.cpp Outdated Show resolved Hide resolved
Source/Core/ElementStyle.cpp Outdated Show resolved Hide resolved
Source/Core/ElementUtilities.cpp Outdated Show resolved Hide resolved
Source/Core/ElementText.cpp Outdated Show resolved Hide resolved
Include/RmlUi/Core/FontEngineInterface.h Show resolved Hide resolved
Include/RmlUi/Core/FontEngineInterface.h Show resolved Hide resolved
@igorsegallafa
Copy link
Contributor Author

Good thoughts, thank you!
ll take some time to implement the tests right now.

@mikke89 mikke89 changed the base branch from develop to master April 8, 2023 10:15
@mikke89 mikke89 force-pushed the feature/add-letter-spacing-rcss branch from 23b3911 to a90b154 Compare April 8, 2023 10:25
@mikke89 mikke89 marked this pull request as ready for review April 8, 2023 12:12
@mikke89 mikke89 merged commit 6df2e64 into mikke89:master Apr 8, 2023
@mikke89
Copy link
Owner

mikke89 commented Apr 8, 2023

Hey, I decided to finish this one up myself, including a visual test, and some efficiency considerations. Thanks for the pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikke89 mikke89 mikke89 left review comments

Assignees
No one assigned
Labels
enhancement New feature or request layout Layout engine issues and enhancements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@igorsegallafa @mikke89