Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable lunasvg to be found if lunasvg is built in tree. #282

Merged
merged 1 commit into from
Feb 7, 2022

Conversation

EhWhoAmI
Copy link

@EhWhoAmI EhWhoAmI commented Feb 7, 2022

The current findlunasvg.cmake does not find lunasvg if it is a target within the build tree of the project.

Adding this would enable RmlUi to find lunasvg if lunasvg is added via add_subdirectory in the project.

@EhWhoAmI
Copy link
Author

EhWhoAmI commented Feb 7, 2022

I believe something like this can also be done with lottie to enable similar functionality.

EhWhoAmI added a commit to EhWhoAmI/cqsp that referenced this pull request Feb 7, 2022
… not come with rmlui.

Note that this still requires mikke89/RmlUi#282 to be accepted, so in the meantime, please be patient and wait for that.
@mikke89 mikke89 added the build Build system and compilation label Feb 7, 2022
@mikke89 mikke89 merged commit 12eeeaa into mikke89:master Feb 7, 2022
@mikke89
Copy link
Owner

mikke89 commented Feb 7, 2022

Thank you! This works well for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants