Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make cmake stop complaining about freetype not being exported #274

Merged
merged 1 commit into from
Feb 18, 2022

Conversation

jonesmz
Copy link

@jonesmz jonesmz commented Feb 5, 2022

A bit of a hack, but it fixes this cmake error for my local build.

A bit of a hack, but it fixes this cmake error for my local build.
@jonesmz
Copy link
Author

jonesmz commented Feb 5, 2022

Note that this only works with a version of freetype that's either imported from the filesystem, or if it's in the same build tree, it needs to be built with BUILD_SHARED_LIBS = off. Otherwise you still need to export the shared freetype library.

@mikke89
Copy link
Owner

mikke89 commented Feb 6, 2022

Note that this only works with a version of freetype that's either imported from the filesystem, or if it's in the same build tree, it needs to be built with BUILD_SHARED_LIBS = off. Otherwise you still need to export the shared freetype library.

Hm, I think CMake does the right thing when linking libraries, so having FreeType as PRIVATE is correct in this case? FreeType is not part of the public interface of RmlUi, so to me I think this one is good to merge.

@mikke89 mikke89 added the build Build system and compilation label Feb 6, 2022
@mikke89 mikke89 merged commit a7dffe2 into mikke89:master Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build system and compilation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants