Fix Lua 0-indexing #247
Merged
Fix Lua 0-indexing #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikke89
reviewed
Oct 18, 2021
…(same as getting/pushing integers but handles changing between 0 and 1 based indexing).
nimble0
force-pushed
the
fix/lua-0-indexing
branch
from
6c8fe65
to
ae02e25
Compare
|
I updated the branch with those changes. I used plain comments but I have noticed some other files appear to be using annotation for some automated documentation generation. |
|
Thanks a lot! Looks great :) No worries about the formatting of the comments, that looks all good. We don't actually use automated documentation generation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #237
The change to correct the tab_index event parameter is a bit hacky.