Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export Rml::Assert #205

Closed
wants to merge 0 commits into from
Closed

export Rml::Assert #205

wants to merge 0 commits into from

Conversation

kinbei
Copy link

@kinbei kinbei commented Jul 16, 2021

No description provided.

@mikke89
Copy link
Owner

mikke89 commented Jul 16, 2021

Hi, thanks for the PR.

I see that Assert() is already declared in Debug.h, although only in debug mode. Is there any reason we want access to this in non-debug builds?

If you want access to this in release mode, I think a cleaner approach is to make a Debug.cpp file and move the definition there.

@kinbei
Copy link
Author

kinbei commented Jul 18, 2021

I see that Assert() is already declared in Debug.h, although only in debug mode. Is there any reason we want access to this in non-debug builds?

Link the release library in debug mode.

@mikke89
Copy link
Owner

mikke89 commented Jul 18, 2021

Hm, alright. Does it work for you if we add RMLUICORE_API to the declaration in Debug.h instead? That seems cleaner to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants