Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add method to reload ElementDocument's stylesheet which resolves #156 #159

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Add method to reload ElementDocument's stylesheet which resolves #156 #159

merged 2 commits into from
Dec 21, 2020

Conversation

lut0pia
Copy link
Contributor

@lut0pia lut0pia commented Dec 21, 2020

No description provided.

@lut0pia lut0pia changed the title Add method to reload ElementDocument's stylesheet Add method to reload ElementDocument's stylesheet for #156 Dec 21, 2020
@lut0pia lut0pia changed the title Add method to reload ElementDocument's stylesheet for #156 Add method to reload ElementDocument's stylesheet which resolves #156 Dec 21, 2020
@lut0pia lut0pia mentioned this pull request Dec 21, 2020
Closed
@lut0pia
Copy link
Contributor Author

lut0pia commented Dec 21, 2020

I'm realizing rereading this that I probably don't need to call UnloadDocument and probably shouldn't either. If I'm not mistaken the document is never truly added to the context by going through Factory::InstanceDocumentStream only so just letting the unique_ptr go out of scope should be fine. What do you think?

@mikke89
Copy link
Owner

mikke89 commented Dec 21, 2020

Thanks! Yes, you're right, we can remove the call to UnloadDocument. Otherwise it looks good :)

@mikke89 mikke89 added the enhancement New feature or request label Dec 21, 2020
@mikke89 mikke89 merged commit b7ff498 into mikke89:master Dec 21, 2020
@mikke89
Copy link
Owner

mikke89 commented Dec 21, 2020

This is great, thanks again!

@LWSS
Copy link
Contributor

LWSS commented Dec 21, 2020

this is cool, maybe I should stop using inline styles lol

@lut0pia
Copy link
Contributor Author

lut0pia commented Dec 21, 2020

If by inline you mean the <style> tags in the <head>, then this does support reloading inline style too! However style attributes on RML elements won't be updated yes :/

@LWSS
Copy link
Contributor

LWSS commented Dec 21, 2020

yeah in the <head> :P

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lut0pia @mikke89 @LWSS