Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WOFF fonts cause double free on exit #217

Closed
nimble0 opened this issue Jul 31, 2021 · 1 comment
Closed

WOFF fonts cause double free on exit #217

nimble0 opened this issue Jul 31, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@nimble0
Copy link

nimble0 commented Jul 31, 2021

Reproducing:

  • Add a WOFF font, such as Xolonium, to Samples/assets
  • Add { "Xolonium-Regular.woff", false }, to the font faces list in Shell.cpp
  • Launch and close any sample

Looks like FreeType::ReleaseFace expects FT_Face->stream->base to hold a pointer to the data pointer that was passed in but in the case of WOFF fonts it doesn't.

@mikke89 mikke89 added the bug Something isn't working label Aug 5, 2021
@mikke89
Copy link
Owner

mikke89 commented Aug 5, 2021

Thank you for the detailed report! The FT_Face->stream->base pointer must certainly have been a hack, I've restructured a bit and it should be fixed now, much safer. Let me know if there are any issues.

@mikke89 mikke89 closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants