feat(cmake): remove LUA_BINDINGS_LINK_LIBS

Signed-off-by: Longtao Zhang <DragonBillow@outlook.com>
mikke89 · Feb 21, 2023 · 4d9c329 · 4d9c329
1 parent 16df3b0
commit 4d9c329
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 9 deletions.
diff --git a/CMake/gen_samplelists.sh b/CMake/gen_samplelists.sh
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -168,10 +168,8 @@ option(BUILD_SAMPLES "Build samples" OFF)
 option(RMLUI_RLOTTIE_EXTERNAL "Use external RLOTTIE" OFF)
 # Use external Lua, for example:
 # add_library(RmlUi_External::Lua ALIAS custom_lua)
-option(RMLUI_LUA_EXTERNAL "Use external LUA, this ask RmlUi_External::Lua target be set" OFF)
 
 mark_as_advanced(RMLUI_RLOTTIE_EXTERNAL)
-mark_as_advanced(RMLUI_LUA_EXTERNAL)
 
 set(SAMPLES_BACKEND "auto" CACHE STRING "Backend platform and renderer used for the samples.")
 set_property(CACHE SAMPLES_BACKEND PROPERTY STRINGS auto Win32_GL2 Win32_VK X11_GL2 SDL_GL2 SDL_GL3 SDL_VK SDL_SDLrenderer SFML_GL2 GLFW_GL2 GLFW_GL3 GLFW_VK)
@@ -366,13 +364,9 @@ endif()
 
 # Lua
 if(BUILD_LUA_BINDINGS)
-	if(${RMLUI_LUA_EXTERNAL})
-		list(APPEND LUA_BINDINGS_LINK_LIBS RmlUi_External::Lua)
-	else()
-		find_package(Lua REQUIRED)
-		list(APPEND LUA_BINDINGS_INCLUDE_DIRS ${LUA_INCLUDE_DIR})
-		list(APPEND LUA_BINDINGS_LINK_LIBS ${LUA_LIBRARIES})
-	endif()
+	find_package(Lua REQUIRED)
+	list(APPEND LUA_BINDINGS_INCLUDE_DIRS ${LUA_INCLUDE_DIR})
+	list(APPEND LUA_BINDINGS_LINK_LIBS ${LUA_LIBRARIES})
 endif()
 
 # rlottie

diff --git a/Dependencies/osx-depends.sh b/Dependencies/osx-depends.sh