[boosty] added new direct message extractor #6768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikf
reviewed
Feb 15, 2025
gallery_dl/extractor/boosty.py
Outdated
| return self._pagination_dialog(endpoint, params) | ||
|
|
||
| def _pagination_dialog(self, endpoint, params): | ||
| all_messages = [] |
There was a problem hiding this comment.
What's this for? You are collecting all message objects to not actually use them?
|
@5n0wstorm
|
- formatting - fixed linting formatting errors - fixed E999 SyntaxError: invalid syntax - fixed class naming - fixed mandatory extractor.boosty.metadata as true requirement - update - apply changes - add test - update docs/supportedsites - improve 'dialog' pagination logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
BoostyDirectMessageExtractoras a new feature to fetch and process Boosty direct messages, including attachments. UpdatesBoostyAPIwithdialog,dialog_messages, and_pagination_dialogmethods for direct message retrieval. Verified that all file types can be successfully downloaded to the best of my capacity.There is possibly a way to always fetch the DMs, but the
_dispatch_extractorsfunction is a bit too complex for me at the moment. Let me know if adjustments are needed or if this is out of scope.