Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I have create a dockerfile thats allows to run this as docker image #192

Closed
wants to merge 2 commits into from
Closed

I have create a dockerfile thats allows to run this as docker image #192

wants to merge 2 commits into from

Conversation

WeslieDE
Copy link

No description provided.

Chris added 2 commits March 15, 2019 22:50
add "Dockerfile"
b3fde46 
Add "Dockerfile" to build a docker image.
add docker commands to readme
10cb127 
add "docker" area to installation in the readme file.
@mikf
Copy link
Owner

mikf commented Mar 17, 2019

I don't think there should be a Dockerfile or Docker instructions hosted here.
Put your Dockerfile on https://hub.docker.com/ if you want to publicize it, but this repository is not the place for it.

Not to mention: This is not how reStructuredText is formatted and your Dockerfile could be simplified quite a bit:

FROM python:3
RUN pip install https://github.com/mikf/gallery-dl/archive/master.zip
ENTRYPOINT [ "gallery-dl" ]

@mikf mikf closed this Mar 17, 2019
@mikf mikf mentioned this pull request Jan 7, 2021
Closed
@mikf mikf mentioned this pull request Nov 20, 2023
Merged
@mikf mikf added the docker label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WeslieDE @mikf