Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hentai.cafe extractor: prefer manga title of /hc.fyi/ #1106

Closed
wants to merge 4 commits into from

Conversation

mo-han
Copy link
Contributor

@mo-han mo-han commented Nov 10, 2020

when set the "manga" metadata, prefer it in the manga page (with /hc.fyi/ in URL), to that in the chapter page
reason: some mangas have different title in manga page and in chapter page

example:
https://hentai.cafe/hc.fyi/1349
this page has title which starts with "[Distance] Devil Sisters!"
while in its chapter page (https://hentai.cafe/manga/read/devil_sisters/en/0/1/page/1), the title starts with "Devil Sisters!"

solution:
for such situations, extract "manga" metadata in /hc.fyi/ page if possible, and reuse it in chapter page

mo-han added 4 commits May 26, 2020 09:22
when set the "manga" metadata, prefer it in the manga page (with /hc.fyi/ in URL), to that in the chapter page
reason: some mangas have different title in manga page and in chapter page

example:
https://hentai.cafe/hc.fyi/1349
this page has title which starts with "[Distance] Devil Sisters!"
while in its chapter page (https://hentai.cafe/manga/read/devil_sisters/en/0/1/page/1), the title starts with "Devil Sisters!"

solution:
for such situations, extract "manga" metadata in /hc.fyi/ page if possible, and reuse it in chapter page
@mikf mikf closed this in 712c792 Dec 27, 2020
@mo-han
Copy link
Contributor Author

mo-han commented Dec 28, 2020

@mikf
hi, would you please add this patch?
don't know how to pass the CI checks, but since this change is very simple, could you add it into new version?
open to any suggestions or decisions

@mikf
Copy link
Owner

mikf commented Dec 28, 2020

It is in the new version, it even says so in the CHANGELOG and release page.
Instead of merging your changes directly, I added commit 712c792, which also cleans up all issues I would have had with your PR.
Titles for /hc.fyi/ URLs now behave how you proposed they should:

$ gallery-dl https://hentai.cafe/hc.fyi/1349
/tmp/hentaicafe/[Distance] Devil Sisters!/c001_001.jpg
/tmp/hentaicafe/[Distance] Devil Sisters!/c001_002.jpg
/tmp/hentaicafe/[Distance] Devil Sisters!/c001_003.jpg
...

@mo-han
Copy link
Contributor Author

mo-han commented Dec 29, 2020

@mikf thx for your work, didn't check changelog, my bad

@mo-han mo-han deleted the hentaicafe-prefer-manga-hcfyi branch December 29, 2020 01:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants