Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Request] Newgrounds "following" support #684

Closed
alferezkururu966 opened this issue Apr 8, 2020 · 5 comments
Closed

[Request] Newgrounds "following" support #684

alferezkururu966 opened this issue Apr 8, 2020 · 5 comments

Comments

@alferezkururu966
Copy link

I think adding support for url like "https://[username].newgrounds.com/favorites/following" would be nice and it's already supported in similar sites (pixiv "https://www.pixiv.net/en/users/[usercode]/following" or patreon "https://www.patreon.com/home").
I think it should download the art of everyone the user is following, each into a different folder, pretty much just like the pixiv one does.

@alferezkururu966
Copy link
Author

Hi first of all thanks for taking the time to implement this, I just tried the (at the moment) last release (v1.13.5) and im getting an error when trying this.

2020-04-28 00:28:52[newgrounds][error] HttpError: InvalidURL: Invalid URL 'https:////yungbird.newgrounds.com/art/page/1': No host supplied

The command i ran is gallery-dl -c config.conf https://tomfulp.newgrounds.com/favorites/following where config is my config file.

@Hrxn
Copy link
Contributor

Hrxn commented Apr 27, 2020

'https:////yungb ...

?

@alferezkururu966
Copy link
Author

Just to be clear, the command im running is gallery-dl -c config.conf https://tomfulp.newgrounds.com/favorites/following
and the output im getting is 2020-04-28 00:28:52[newgrounds][error] HttpError: InvalidURL: Invalid URL 'https:////yungbird.newgrounds.com/art/page/1': No host supplied
I do realise that its suposed to be https://yun .... as you can see https://tomfulp.newgrounds.com/favorites/following is properly writen

@mikf
Copy link
Owner

mikf commented Apr 29, 2020

Sorry about that. It was working when I implemented this feature, then Newgrounds added two extra // before each username, and the tests didn't pick it up. Should be fixed with c56a751

@alferezkururu966
Copy link
Author

No need to apologize, guess I was a bit late to try the feature since I use the .exe releases.
Thanks for fixing it tho!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants