Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SubscribeStar.adult] Embeds and attachments not downloading #6721

Closed
KamiYamabushi opened this issue Dec 25, 2024 · 2 comments · Fixed by #6758
Closed

[SubscribeStar.adult] Embeds and attachments not downloading #6721

KamiYamabushi opened this issue Dec 25, 2024 · 2 comments · Fixed by #6758
Labels
site:change

Comments

@KamiYamabushi
Copy link

As of the latest version of gallery-dl, seems that embeds and attachments are not downloading (for example, embedded mp3s or attached zip files).

There do not appear to be any issues with cookies or accessing posts (via --verbose) - just everything in the post, except the image used for the post, is not downloaded for some reason.
@mikf mikf mentioned this issue Dec 25, 2024
Closed
@mikf
Copy link
Owner

mikf commented Dec 25, 2024

Does reverting to an older version fix this issue?

Having the Subscribestar HTML from --write-pages of posts/pages gallery-dl fails to extract embeds and attachments from would really help.

@Nightmare-Serene
Copy link

Does reverting to an older version fix this issue?

Having the Subscribestar HTML from --write-pages of posts/pages gallery-dl fails to extract embeds and attachments from would really help.

Still can't do it

@Hrxn Hrxn mentioned this issue Dec 29, 2024
Open
WyohKnott added a commit to WyohKnott/gallery-dl that referenced this issue Jan 2, 2025
@WyohKnott
Fix attachment download and add support for audio type
3cd314e 
 - We change the text.extr 3rd argument to match current structure
   ('class="post-edit_form"')
 - We add support for uploads-audios based on a similar structure as the
   attachment type:
    - id = data-upload-id
    - name = audio_preview-title
    - url = src
    - type = audio

Fix mikf#6721
WyohKnott added a commit to WyohKnott/gallery-dl that referenced this issue Jan 2, 2025
@WyohKnott
Fix attachment download and add support for audio type
a994f36 
 - We change the text.extr 3rd argument to match current structure
   ('class="post-edit_form"')
 - We add support for uploads-audios based on a similar structure as the
   attachment type:
    - id = data-upload-id
    - name = audio_preview-title
    - url = src
    - type = audio

Fix mikf#6721
@WyohKnott WyohKnott mentioned this issue Jan 2, 2025
Merged
@mikf mikf closed this as completed in a46f798 Jan 2, 2025
mikf added a commit that referenced this issue Jan 2, 2025
@mikf
merge #6758: [subscribestar] fix attachment downloads and add support…
5767c08 
… for audio type

(#6721, #>6724)
@mikf mikf mentioned this issue Jan 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
site:change
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[subscribestar] Fix attachment download and add support for audio type WyohKnott/gallery-dl
3 participants
@mikf @KamiYamabushi @Nightmare-Serene