Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flickr download issue _d applied to mp4 files #6464

Closed
chrislewisdev2 opened this issue Nov 13, 2024 · 0 comments
Closed

flickr download issue _d applied to mp4 files #6464

chrislewisdev2 opened this issue Nov 13, 2024 · 0 comments
Labels

Comments

@chrislewisdev2
Copy link

I had the same issue as #6360 and once the fix got committed, tried the nightly build and it worked great. I could then download JPEG files.

But I noticed when running on an album, it will not do the mp4 files as it fails when you add the _d to the filename. Some additional logic is needed to check the file type because mp4s worked fine in the previous version so I assume that doesn't need the extra _d.

If I get time to set this up, I'll do a PR.

Thank you for writing this utility - it is great.

@mikf mikf added the site:bug label Nov 13, 2024
mikf added a commit that referenced this issue Nov 13, 2024
continuation of 0e18fa3
fix video detection in '_file_url'
@mikf mikf closed this as completed Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants