Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tumblr, reblogs are downloaded as well. (bug or not?) #61

Closed
yomanbest opened this issue Jan 5, 2018 · 9 comments
Closed

Tumblr, reblogs are downloaded as well. (bug or not?) #61

yomanbest opened this issue Jan 5, 2018 · 9 comments

Comments

@yomanbest
Copy link

My thanks for the creators of this beautiful tool. Lately my tumblr blog URL downloads contain not only original posts, but reblogs as well, which I haven't seen happening before, but I'm not sure if its a bug or not. My current version is 1.1.1. Can provide logs if needed.

@Hrxn
Copy link
Contributor

Hrxn commented Jan 5, 2018

Not a bug, I'd say. These are the same reblogs you would see when visiting that blog on Tumblr in your browser, right?

Anyway, gallery-dl gets whatever is returned by the API as posts, so this is intentional. Although it should be possible to add as an additional feature, filtering out reblogs.

@yomanbest
Copy link
Author

yomanbest commented Jan 5, 2018

Decided to double-check my already downloaded galleries. It seems that you're right ; I did find reblogs there as well.

Well, I guess this is a feature request now ??

Anyway, thanks for the quick answer, have a nice day.

mikf added a commit that referenced this issue Jan 5, 2018
Reblogs are ignored by default, but can be included by setting
'extractor.tumblr.reblogs' to 'true'.
@mikf
Copy link
Owner

mikf commented Jan 5, 2018

I'm not entirely certain about the default value for this option, so I just wanted to ask someone who actually uses/knows Tumblr: should reblogs rather be included (how it has been) or excluded (like d235f68 implements) by default?

@yomanbest
Copy link
Author

yomanbest commented Jan 5, 2018

I'd say reblogs should be excluded by default because different content gets mixed along the blog-original content, which, at least for me, is a no-no. Ex.: Downloading a blog full of kitten photos only to see reblogged posts of toy-cars, or something, in the download folder.

@Hrxn
Copy link
Contributor

Hrxn commented Jan 6, 2018

To be honest, I'd argue otherwise.
You are right about the mixed content (depending on the blog / the Tumblr user), and that is something you would potentially not want to download.

But the reblogged stuff is what you see when visiting the blog in question in your browser.
And it seems more reasonable to me that gallery-dl gets you what you can see in the browser, by default.

But I'm not necessarily against this change, don't get me wrong. For me personally, both would be fine.
My gallery-dl.conf is at some 490 lines right now, as far as I know, so adding just one more setting would not make any more difference for me 😄

@yomanbest
Copy link
Author

yomanbest commented Jan 6, 2018

I kind of agree of you, but I was mostly thinking of artist blogs, that reblog art from others as well, rather than a normal post blog. You would expect to see their art only, when the download is completed, rather than having mixed art from different unknown sources.

But yes, in the end it's all about the blog type. In my case, I only download artist blogs and I don't really appreciate ending up with mixed art without a clear signtaure or source.
Imho this issue could be solved by asking the users what type of blogs they download mostly.
To finally end this long reply, I agree that reblogs are a crucial part of tumblr itself and in the end I'm good with whatever choice mikf makes, having an option to filter them out is good enough for me.

mikf added a commit that referenced this issue Jan 6, 2018
@mikf
Copy link
Owner

mikf commented Jan 6, 2018

I agree with HRXN's point in that, by default, you would expect to download all posts of a Tumblr user, reblog or not, as this is what you see when visiting with your browser. Including reblogs by default has also always been a "feature" (intentional or not), so I would rather want to keep it this way.

@mikf mikf closed this as completed Jan 6, 2018
@KaMyKaSii
Copy link

@mikf so we will not have any parameters to skip reblogs?

@mikf
Copy link
Owner

mikf commented Sep 6, 2018

There is extractor.tumblr.reblogs, implemented in d235f68 as mentioned above. Set it to false to skip reblogged posts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants