-
-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tumblr, reblogs are downloaded as well. (bug or not?) #61
Comments
Not a bug, I'd say. These are the same reblogs you would see when visiting that blog on Tumblr in your browser, right? Anyway, gallery-dl gets whatever is returned by the API as |
Decided to double-check my already downloaded galleries. It seems that you're right ; I did find reblogs there as well. Well, I guess this is a Anyway, thanks for the quick answer, have a nice day. |
Reblogs are ignored by default, but can be included by setting 'extractor.tumblr.reblogs' to 'true'.
I'm not entirely certain about the default value for this option, so I just wanted to ask someone who actually uses/knows Tumblr: should reblogs rather be included (how it has been) or excluded (like d235f68 implements) by default? |
I'd say reblogs should be |
To be honest, I'd argue otherwise. But the reblogged stuff is what you see when visiting the blog in question in your browser. But I'm not necessarily against this change, don't get me wrong. For me personally, both would be fine. |
I kind of agree of you, but I was mostly thinking of artist blogs, that reblog art from others as well, rather than a normal post blog. You would expect to see their art only, when the download is completed, rather than having mixed art from different unknown sources. But yes, in the end it's all about the blog type. In my case, I only download artist blogs and I don't really appreciate ending up with mixed art without a clear signtaure or source. |
I agree with HRXN's point in that, by default, you would expect to download all posts of a Tumblr user, reblog or not, as this is what you see when visiting with your browser. Including reblogs by default has also always been a "feature" (intentional or not), so I would rather want to keep it this way. |
@mikf so we will not have any parameters to skip reblogs? |
There is extractor.tumblr.reblogs, implemented in d235f68 as mentioned above. Set it to |
My thanks for the creators of this beautiful tool. Lately my tumblr blog URL downloads contain not only original posts, but reblogs as well, which I haven't seen happening before, but I'm not sure if its a bug or not. My current version is 1.1.1. Can provide logs if needed.
The text was updated successfully, but these errors were encountered: