Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Classify postprocessor, when re-checking downloaded archive it re-downloads them then skips? #5213

Closed
dazzaXx opened this issue Feb 19, 2024 · 3 comments

Comments

@dazzaXx
Copy link

dazzaXx commented Feb 19, 2024

Hello,

I have the classify postprocessor setup to filter images, videos and archive file types and while it does work, it seems that when i want to re-run my script to check if there is anything new from the links, it redownloads the files first, THEN checks if it is there and skips it.

Is there anyway to tell it to check these folders first instead of after?

It might just be me to be fair, but by it doing this, slows the process down a lot, just to see if something new is there or not.

Thank you.

P.S. Apologies if this has already been asked or if I'm being stupid.

@dazzaXx
Copy link
Author

dazzaXx commented Feb 19, 2024

Hi,

Yes it was me being stupid, after specifying to use an archive database that creates the sqlite3 files, it knows what to skip.

@dazzaXx dazzaXx closed this as completed Feb 19, 2024
@mikf
Copy link
Owner

mikf commented Feb 19, 2024

Well yes, using an archive works, but skipping already downloaded files without it when using classify is also supposed to work. Turns out this is a bug introduced in commit 8124c16.

(I actually got to use git bisect for once)

@dazzaXx
Copy link
Author

dazzaXx commented Feb 19, 2024

Ooh okay, I thought it was a problem on my end. Glad I mentioned this then!

mikf added a commit that referenced this issue Nov 20, 2024
Do not manually build paths, which get later overwritten by
pathfmt.build_path() anyway. Just update the target directory and let
the rest of the "path logic" handle it.

Fixes skipping previously downloaded and categorized files,
which was broken since 8124c16
@mikf mikf closed this as completed Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants