Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

patreon rip is reading my home feed when it's fed a patreon page that no longer exists. #3235

Closed
left1000 opened this issue Nov 16, 2022 · 2 comments
Labels

Comments

@left1000
Copy link

left1000 commented Nov 16, 2022

patreon rip is reading my home feed when it's fed a patreon page that no longer exists.

So, I've got a list of my favorite patreons, that I copy/paste into the cli to update my rips.

One of the artists deleted their patreon, and now that same copy/paste tries to rip my entire homepage feed in that slot instead of skipping over it.

So, uh, yeah, gallery-dl see's

This patron isn’t supporting any creators at the moment.

and just treats it as if I tried to rip patreon.com instead of patreon.com/artistname.

Ideally deleted pages would not have this result.

edit: note, I let it finish entirely, and it actually for some reason just rips the first artist on my list of followed artists off my homepage, anytime it's fed another artist's deleted page.

@mikf
Copy link
Owner

mikf commented Nov 18, 2022

Could you post a --verbose log of this happening?
When I'm trying to download from a non-existing user, it gives me a 404 and correctly reports it (with and without logged in cookies):

$ gallery-dl -v patreon.com/404notfound
...
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /404notfound/posts HTTP/1.1" 301 None
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /404NOTFOUND/posts HTTP/1.1" 302 None
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /404NOTFOUND HTTP/1.1" 200 None
[patreon][error] NotFoundError: Requested creator could not be found

$ gallery-dl -v patreon.com/asdfrghj
...
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /asdfrghj/posts HTTP/1.1" 404 None
[patreon][error] NotFoundError: Requested creator could not be found

Maybe just checking for a redirect is good enough?

@left1000
Copy link
Author

left1000 commented Nov 18, 2022

This bug requires a user that does exist but has deleted their creator page. It does say

This patron isn’t supporting any creators at the moment.

just like your example but:

PS D:\gallery-dl> .\gallery-dl -vv https://www.patreon.com/teamspoon
[gallery-dl][debug] Version 1.23.5 - Executable
[gallery-dl][debug] Python 3.7.9 - Windows-10-10.0.19041
[gallery-dl][debug] requests 2.28.1 - urllib3 1.26.12
[gallery-dl][debug] Starting DownloadJob for 'https://www.patreon.com/teamspoon'
[patreon][debug] TLS 1.2 disabled.
[patreon][debug] Using PatreonCreatorExtractor for 'https://www.patreon.com/teamspoon'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): www.patreon.com:443
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /teamspoon/posts HTTP/1.1" 302 None
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /user?u=278279 HTTP/1.1" 200 None
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /api/posts?include=user,images,attachments,user_defined_tags,campaign,poll.choices,poll.current_user_responses.user,poll.current_user_responses.choice,poll.current_user_responses.poll,access_rules.tier.null&fields%5Bpost%5D=change_visibility_at,comment_count,content,current_user_can_delete,current_user_can_view,current_user_has_liked,embed,image,is_paid,like_count,min_cents_pledged_to_view,post_file,published_at,patron_count,patreon_url,post_type,pledge_url,thumbnail_url,teaser_text,title,upgrade_url,url,was_posted_by_campaign_owner&fields%5Buser%5D=image_url,full_name,url&fields%5Bcampaign%5D=avatar_photo_url,earnings_visibility,is_nsfw,is_monthly,name,url&fields%5Baccess_rule%5D=access_rule_type,amount_cents&sort=-published_at&filter%5Bis_draft%5D=false&filter%5Bcontains_exclusive_posts%5D=true&filter%5Bcampaign_id%5D=93174&json-api-use-default-includes=false&json-api-version=1.0 HTTP/1.1" 200 None
[patreon][warning] Not allowed to view post 74690234
[patreon][warning] Not allowed to view post 74329882
[patreon][warning] Not allowed to view post 74074515
[urllib3.connectionpool][debug] https://www.patreon.com:443 "GET /api/user/166673 HTTP/1.1" 200 None
[patreon][debug] Using download archive './gallery-dl/archive.sqlite3'
[patreon][debug] Active postprocessor modules: [MtimePP, MetadataPP]
[patreon][warning] Not allowed to view post 73645614

no clue why it's doing this and moving to another creator without being told to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants