Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[imgur] Infinitely downloading nothing. #1561

Closed
AnExcitedElectron opened this issue May 16, 2021 · 3 comments
Closed

[imgur] Infinitely downloading nothing. #1561

AnExcitedElectron opened this issue May 16, 2021 · 3 comments

Comments

@AnExcitedElectron
Copy link

AnExcitedElectron commented May 16, 2021

Hi. While downloading a subreddit, one link, when followed, leads to an infinite continuation of downloads. Behold:

[imgur][debug] Using ImgurSubredditExtractor for 'https://m.imgur.com/r/Celebs/iHJ7tsM'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/0 HTTP/1.1" 200 450
[imgur][debug] Using ImgurImageExtractor for 'https://i.imgur.com/m7eoaJt.jpg'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /post/v1/media/m7eoaJt?include=media%2Ctags%2Caccount HTTP/1.1" 200 482
[imgur][debug] Using download archive '/home/user/.red/mileycyrusarchive'
/home/user/RED/mileycyrus - all/imgur/imgur_m7eoaJt_Lucy Liu always takes the stairs.jpg
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/1 HTTP/1.1" 200 442
[imgur][debug] Using ImgurImageExtractor for 'https://i.imgur.com/87CJZiC.jpg'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /post/v1/media/87CJZiC?include=media%2Ctags%2Caccount HTTP/1.1" 200 459
[imgur][debug] Using download archive '/home/user/.red/mileycyrusarchive'
/home/user/RED/mileycyrus - all/imgur/imgur_87CJZiC_Judy Landers.jpg
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/2 HTTP/1.1" 200 475
[imgur][debug] Using ImgurImageExtractor for 'https://i.imgur.com/qRaiC7q.mp4'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /post/v1/media/qRaiC7q?include=media%2Ctags%2Caccount HTTP/1.1" 200 464
[imgur][debug] Using download archive '/home/user/.red/mileycyrusarchive'
/home/user/RED/mileycyrus - all/imgur/imgur_qRaiC7q_Olivia Taylor Dudley.mp4
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/3 HTTP/1.1" 200 500
[imgur][debug] Using ImgurImageExtractor for 'https://i.imgur.com/O1icuAh.jpg'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /post/v1/media/O1icuAh?include=media%2Ctags%2Caccount HTTP/1.1" 200 520
[imgur][debug] Using download archive '/home/user/.red/mileycyrusarchive'
/home/user/RED/mileycyrus - all/imgur/imgur_O1icuAh_Jennifer Grey makes out with Mia Sara between takes filming on the set of Ferris Bueller's Day Off in 1986.jpg
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/4 HTTP/1.1" 200 482
[imgur][debug] Using ImgurImageExtractor for 'https://i.imgur.com/eWXNLGJ.gif'
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /post/v1/media/eWXNLGJ?include=media%2Ctags%2Caccount HTTP/1.1" 200 460
[imgur][debug] Using download archive '/home/user/.red/mileycyrusarchive'
/home/user/RED/mileycyrus - all/imgur/imgur_eWXNLGJ_Emma Watson.mp4

So far, so good. Then, this:

[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/5 HTTP/1.1" 200 449
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/6 HTTP/1.1" 200 443
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/7 HTTP/1.1" 200 476
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/8 HTTP/1.1" 200 501
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/9 HTTP/1.1" 200 483
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/10 HTTP/1.1" 200 449
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/11 HTTP/1.1" 200 443
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/12 HTTP/1.1" 200 476
[urllib3.connectionpool][debug] https://api.imgur.com:443 "GET /3/gallery/r/Celebs/13 HTTP/1.1" 200 501

And so on, infinitely. I left it running and it was on 3500 when I got back, with nothing downloaded.
Appreciably, this may be a thing only with this one webpage, but thought you ought to know regardless.

EDIT: Version info.

[gallery-dl][debug] Version 1.17.4
[gallery-dl][debug] Python 3.9.5 - Linux-5.4.0-73-generic-x86_64-with-glibc2.27
[gallery-dl][debug] requests 2.25.1 - urllib3 1.26.4

EDIT2: Attempted replication and failed. Feel free to close/ignore.

@Hrxn
Copy link
Contributor

Hrxn commented May 18, 2021

  1. Not a full log, I can't see your gallery-dl version (and Python version). Please run gallery-dl -v
  2. It should not "read" comments by default.. can you try it with --ignore-config for a test?

@sourmilk01
Copy link

Can you also share your config for imgur (if you have one).

mikf added a commit that referenced this issue May 22, 2021
@mikf
Copy link
Owner

mikf commented May 22, 2021

There are 2 issues here:

  • https://m.imgur.com/r/Celebs/iHJ7tsM gets matched as just imgur.com/r/Celebs and gallery-dl tries to download all /r/Celebs imgur posts (fixed in 4fc9668)
  • going through imgur.com/r/Celebs loops endlessly, with both official API and in browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants