Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--no-skip cannot be used with archive #1023

Closed
kattjevfel opened this issue Sep 22, 2020 · 0 comments
Closed

--no-skip cannot be used with archive #1023

kattjevfel opened this issue Sep 22, 2020 · 0 comments
Labels

Comments

@kattjevfel
Copy link
Contributor

When using either -o skip=false or --no-skip and try to re-download a file, I get the following error:

[gallery-dl][debug] Version 1.15.0
[gallery-dl][debug] Python 3.8.5 - Linux-5.8.10-17-tkg-upds-x86_64-with-glibc2.2.5
[gallery-dl][debug] requests 2.24.0 - urllib3 1.25.10
[gallery-dl][debug] Starting DownloadJob for 'https://danbooru.donmai.us/posts/4115424'
[danbooru][debug] Using DanbooruPostExtractor for 'https://danbooru.donmai.us/posts/4115424'
[urllib3.connectionpool][debug] Starting new HTTPS connection (1): danbooru.donmai.us:443
[urllib3.connectionpool][debug] https://danbooru.donmai.us:443 "GET /posts/4115424.json HTTP/1.1" 200 None
[danbooru][debug] Using download archive '/mnt/jupiter/Temp/gallery-dl/archives/danbooru.sqlite3'
[danbooru][debug] Active postprocessor modules: [ExecPP, UgoiraPP]
/mnt/jupiter/Temp/gallery-dl/danbooru/danbooru_4115424.jpg
[danbooru][error] An unexpected error occurred: AttributeError - 'DownloadJob' object has no attribute '_skipexc'. Please run gallery-dl again with the --verbose flag, copy its output and report this issue on https://github.com/mikf/gallery-dl/issues .
[danbooru][debug] 
Traceback (most recent call last):
  File "/usr/lib/python3.8/site-packages/gallery_dl/job.py", line 68, in run
    self.dispatch(msg)
  File "/usr/lib/python3.8/site-packages/gallery_dl/job.py", line 102, in dispatch
    self.handle_url(url, kwds)
  File "/usr/lib/python3.8/site-packages/gallery_dl/job.py", line 233, in handle_url
    self.handle_skip()
  File "/usr/lib/python3.8/site-packages/gallery_dl/job.py", line 339, in handle_skip
    if self._skipexc:
AttributeError: 'DownloadJob' object has no attribute '_skipexc'

I removed the archive line ("archive": "/mnt/jupiter/Temp/gallery-dl/archives/{category}.sqlite3",) and it worked just perfect, but obviously I shouldn't have to disable the archive when using this.
I also tried removing {category} from the archive path in case that were causing trouble, but it was of no help.

@mikf mikf closed this as completed in d5fa716 Sep 23, 2020
@mikf mikf added the bug label Sep 23, 2020
Korvox pushed a commit to Korvox/gallery-dl that referenced this issue Sep 26, 2020
Separating the archive check from pathfmt.exists() in b524329
had some unintended side effects.

It is also not possible to monkey-patch a dunder method like
__contains__ because of the special method lookup that gets
performed for them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants