matlab like array indexing #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Maik, I like where this is going, but not sure if we've quite bottomed out the API yet. We should do this before we merge into the public API. Can you either:
|
|
Hi, I created a new branch selector in my fork and moved the selector functions to a new namespace clojure.core.matrix.select. It seems github doesn't let me do a pull request which would create a new branch. Can you merge it in if you think it is okay? |
|
That sounds fine to me... but did you push to GitHub? I'm still seeing the old commits.... |
|
ups, i pushed it now |
|
Look good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First version of the matlab style array indexing function proposed here: https://groups.google.com/forum/#!topic/numerical-clojure/zFjIl8zgX6M , to discuss the syntax.
Currently only supports getting elements, not setting them. Maybe another method for this would be the best way of adding it.
Supports all of http://www.mathworks.de/company/newsletters/articles/matrix-indexing-in-matlab.html except the setting of the selected indices.