Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license caching not properly checking fallback license url #1087

Merged
merged 1 commit into from
Feb 16, 2025

Conversation

mikepenz
Copy link
Owner

…n did store the non fallback as checked in the `remoteLicenseCache`

    - FIX #1085
@mikepenz mikepenz added the fix label Feb 16, 2025
@mikepenz
Copy link
Owner Author

If the cache includes the key because a url was checked before, we still wanna return null to ensure fallback fetching occurs:

@mikepenz mikepenz merged commit cd5594c into develop Feb 16, 2025
3 checks passed
@mikepenz mikepenz deleted the fix/1085 branch February 16, 2025 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Reproducibility issue] First-time build and subsequent builds don't produce the exact same "licenses" section
1 participant