Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev -> main #1078

Merged
merged 26 commits into from
Feb 14, 2025
Merged

dev -> main #1078

merged 26 commits into from
Feb 14, 2025

Conversation

mikepenz
Copy link
Owner

No description provided.

mikepenz and others added 26 commits January 24, 2025 16:15
- move sample app classes to kotlin source folder
- update to kotlinX serialization 1.8.0
- cleanup
Use `fromHtml` via `AnnotatedString` on Android
Add ability to show description in compose UI
  - will keep original name or url as defined in pom.xml
Add flag to skip spdx license name/url/content mapping
<activity
android:name="com.mikepenz.aboutlibraries.sample.ComposeActivity"
android:exported="true"
android:label="@string/app_name"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Redundant label can be removed

android:theme="@style/SampleApp.DayNight" />
android:name="com.mikepenz.aboutlibraries.sample.FragmentActivity"
android:exported="false"
android:label="@string/app_name"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Redundant label can be removed

android:theme="@style/SampleApp.DayNight" />
android:name="com.mikepenz.aboutlibraries.sample.ExtendActivity"
android:exported="false"
android:label="@string/app_name"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Redundant label can be removed

android:theme="@style/SampleApp.DayNight" />
android:name="com.mikepenz.aboutlibraries.sample.CustomSortActivity"
android:exported="false"
android:label="@string/app_name"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Redundant label can be removed

import androidx.compose.foundation.layout.windowInsetsPadding
import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.BottomDrawer

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Using a material import while also using the material3 library

import androidx.compose.foundation.rememberScrollState
import androidx.compose.foundation.verticalScroll
import androidx.compose.material.BottomDrawer
import androidx.compose.material.BottomDrawerValue

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Using a material import while also using the material3 library

import androidx.compose.foundation.verticalScroll
import androidx.compose.material.BottomDrawer
import androidx.compose.material.BottomDrawerValue
import androidx.compose.material.Switch

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Using a material import while also using the material3 library

import androidx.compose.material.icons.filled.Menu
import androidx.compose.material.icons.filled.Person
import androidx.compose.material.icons.filled.Settings
import androidx.compose.material.rememberBottomDrawerState

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Using a material import while also using the material3 library

kotlinxCollections = "0.3.8"
# androidx
activity = "1.10.0"
cardview = "1.0.0"
constraintLayout = "2.2.0"
core = "1.15.0"
lifecycle = { require = "2.8.7" }
navigation = "2.8.5"
navigation = "2.8.6"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of androidx.navigation.safeargs than 2.8.6 is available: 2.8.7

kotlinxCollections = "0.3.8"
# androidx
activity = "1.10.0"
cardview = "1.0.0"
constraintLayout = "2.2.0"
core = "1.15.0"
lifecycle = { require = "2.8.7" }
navigation = "2.8.5"
navigation = "2.8.6"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of androidx.navigation:navigation-fragment than 2.8.6 is available: 2.8.7

kotlinxCollections = "0.3.8"
# androidx
activity = "1.10.0"
cardview = "1.0.0"
constraintLayout = "2.2.0"
core = "1.15.0"
lifecycle = { require = "2.8.7" }
navigation = "2.8.5"
navigation = "2.8.6"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ A newer version of androidx.navigation:navigation-safe-args-gradle-plugin than 2.8.6 is available: 2.8.7

@mikepenz mikepenz merged commit eec972f into main Feb 14, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant