Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross Site Scripting issue with NON-GET dialog #98

Open
msturm opened this issue Dec 22, 2017 · 1 comment
Open

Cross Site Scripting issue with NON-GET dialog #98

msturm opened this issue Dec 22, 2017 · 1 comment

Comments

@msturm
Copy link

msturm commented Dec 22, 2017

If you open the NON-GET dialog and press submit, you get a URL of the form: http://haltalk.herokuapp.com/explorer/browser.html#NON-GET:/

If you modify the URL to include javascript for example, it turns out that the contents are displayed in the users' browser. Theoretically, this makes it possible to perform various actions, including stealing cookies etc.

An example to see the problem described above is going to this link on the demo-app of the HAL-browser:
http://haltalk.herokuapp.com/explorer/browser.html#NON-GET:/">'<script>alert("hi")</script>

msturm added a commit to msturm/hal-browser that referenced this issue Dec 22, 2017
@msturm
Copy link
Author

msturm commented Dec 22, 2017

I was creating a pull request, but then noticed that this pull request is already fixing this issue:
#97

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant