Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wanted to see if you would be open to allowing flexibility on the route where metrics where exposed? #34

Open
froozcode opened this issue May 25, 2016 · 2 comments
Assignees

Comments

@froozcode
Copy link

Looks like per server.js (/metrics) is the preferred endpoint where the data gets exposed. Would you be open to a pull request that would allow this to be changed? examples could be /stats, /health, etc. Basically whatever is passed in as a parameter. Thank you!

@mikejihbe
Copy link
Owner

I don't want to require a version bump, so we need to handle this function
signature, but yes.

Let's make the first argument to
https://github.com/mikejihbe/metrics/blob/master/reporting/server.js#L9
accept either a numerical port or an options object with port and path in
it, then add some documentation.

On Wed, May 25, 2016 at 2:08 PM, Frank Ruiz notifications@github.com
wrote:

Looks like per server.js (/metrics) is the preferred endpoint where the
data gets exposed. Would you be open to a pull request that would allow
this to be changed? examples could be /stats, /health, etc. Basically
whatever is passed in as a parameter. Thank you!


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#34

Mike Ihbe
MustWin - Principal

mike@mustwin.com
mikejihbe@gmail.com
skype: mikeihbe
Cell: 651.283.0815

@froozcode
Copy link
Author

Awesome. I forked the repo, and will start making the necessary modifications. I'll send over a pull request shortly... thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants