Problem: ansible-pulp CI is failing as of molecule 3.0's release

Solution:

Follow molecule 3.0 migration guide:
ansible/molecule#2560

Implementation includes:
1. Installing ansible-lint and molecule-inspec explicitly.
2. Reworking lint sections of molecule.yml files
3. Renaming playbook.yml symlinks to converge.yml

Fixes: #6211

README.md

@@ -119,8 +119,11 @@ and so on.
 
 **Using Molecule:**
 
-1. Install [molecule](https://molecule.readthedocs.io/en/latest/). It is recommended that you do so
-   with `pip` in a virtualenv.
+1. Install [molecule](https://molecule.readthedocs.io/en/latest/)
+[molecule-inspec](https://github.com/ansible-community/molecule-inspec),
+and [ansible-lint](https://docs.ansible.com/ansible-lint/).
+
+It is recommended that you do so with `pip` in a virtualenv.
 2. Run molecule commands.
 
    Test all scenarios on all hosts.

molecule/default-upgrade/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -40,10 +42,7 @@ provisioner:
   inventory:
     links:
       host_vars: ../scenario_resources/host_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: default-upgrade
   test_sequence:
     - lint
     - dependency
@@ -56,6 +55,3 @@ scenario:
     - verify
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

molecule/default/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -37,10 +39,7 @@ provisioner:
     links:
       host_vars: ../scenario_resources/host_vars/
       group_vars: ../scenario_resources/group_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: default
   test_sequence:
     - lint
     - dependency
@@ -53,6 +52,3 @@ scenario:
     - verify
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

molecule/dynamic/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -37,10 +39,7 @@ provisioner:
     links:
       host_vars: ../scenario_resources/host_vars/
       group_vars: ../scenario_resources/group_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: dynamic
   test_sequence:
     - lint
     - dependency
@@ -53,6 +52,3 @@ scenario:
     - verify
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

molecule/source-dynamic/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -33,10 +35,7 @@ provisioner:
     links:
       host_vars: ../scenario_resources/host_vars/
       group_vars: ../scenario_resources/group_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: source-dynamic
   test_sequence:
     - lint
     - dependency
@@ -52,6 +51,3 @@ scenario:
 
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

molecule/source-upgrade/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -35,10 +37,7 @@ provisioner:
   inventory:
     links:
       host_vars: ../scenario_resources/host_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: source-upgrade
   test_sequence:
     - lint
     - dependency
@@ -57,6 +56,3 @@ scenario:
     prepare: prepare.yml
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

molecule/source/molecule.yml

@@ -4,8 +4,10 @@ dependency:
   role-file: requirements.yml
 driver:
   name: docker
-lint:
-  name: yamllint
+lint: |
+    yamllint
+    ansible-lint
+    # rubocop
 # This is ignored by molecule, but can be reused in yaml
 .platform_base: &platform_base
   privileged: False
@@ -33,10 +35,7 @@ provisioner:
     links:
       host_vars: ../scenario_resources/host_vars/
       group_vars: ../scenario_resources/group_vars/
-  lint:
-    name: ansible-lint
 scenario:
-  name: source
   test_sequence:
     - lint
     - dependency
@@ -52,6 +51,3 @@ scenario:
 
 verifier:
   name: inspec
-  lint:
-    name: rubocop
-    enabled: false

tox.ini

@@ -8,8 +8,10 @@ skipsdist = true
 sitepackages = true
 deps =
     ansible
+    ansible-lint
     docker
     molecule
+    molecule-inspec
 passenv = TRAVIS_WAIT
 whitelist_externals =
     travis-wait-enhanced