Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor promises #11

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Refactor promises #11

merged 1 commit into from
Nov 20, 2017

Conversation

benjamingr
Copy link
Contributor

Refactor promise usage in the code - removing the resolvable() function and returning from fetch which already returns a promise.

I wonder if this helps with the file size :)

Fixes #10

@mikeal
Copy link
Owner

mikeal commented Sep 5, 2017

Travis is broken right now cause of a config issue I can't resolve until I get the npm name, are all the tests passing?

@benjamingr
Copy link
Contributor Author

Yes, at least on my machine. I wouldn't submit a PR otherwise without saying so.

This is not urgent - it's a code style fix so there is no rush about it.

Let me know if there is any help I can offer with the CI - I'm generally bad with CIs so I try to pick up opportunities to learn.

@benjamingr
Copy link
Contributor Author

Hey @mikeal are you still looking into integrating this? Let me know if I should resolve the conflicts and continue work. Again - only if this works out for you and feel free to say you don't have time/motivation to work on this and I'll drop it with no hard feelings <3

@mikeal
Copy link
Owner

mikeal commented Oct 30, 2017

yes, i would love to merge this :)

@ewolfe
Copy link

ewolfe commented Nov 14, 2017

@benjamingr thanks for working on this, would you mind fixing the conflicting files?

@benjamingr
Copy link
Contributor Author

Sorry, forgot about this - just did the change again and force pushed.

@ewolfe
Copy link

ewolfe commented Nov 14, 2017

Looks like this is good to go @mikeal

@mikeal mikeal merged commit 012ce00 into mikeal:master Nov 20, 2017
@mikeal
Copy link
Owner

mikeal commented Apr 6, 2018

🎉 This PR is included in version 2.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants