Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reveal Enterprise-Scale TypeScript v2 #908

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Reveal Enterprise-Scale TypeScript v2 #908

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
a865142
Enable TS Fundamentals v4
mike-north Oct 21, 2023
07c1125
update test
mike-north Oct 21, 2023
4ef1b0d
Update tests
mike-north Oct 21, 2023
fa961d4
Enable Intermediate TS v2
mike-north Oct 21, 2023
497de2a
Update test
mike-north Oct 21, 2023
f50e628
Update tests
mike-north Oct 21, 2023
ce9f592
Enable Enterprise TS v2
mike-north Oct 21, 2023
76ded91
Update tests
mike-north Oct 21, 2023
0b0f862
Merge branch 'main' into reveal-enterprise-v2
mike-north Oct 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions packages/website/content/courses.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,17 @@ courses:
summary: |
Tackle a series of challenges designed to reinforce your knowledge and make
the important concepts truly "stick" in your mind.
- name: Enterprise TypeScript v2
- name: Enterprise-Scale TypeScript v2
id: enterprise-v2
squareImage: /full-stack-ts.png
facebookImage: /fb-full-stack-ts.png
twitterImage: /tw-full-stack-ts.png
squareImage: /enterprise-ts-v2.png
facebookImage: /fb-enterprise-ts-v2.png
twitterImage: /tw-enterprise-ts-v2.png
femCourseUrl: https://frontendmasters.com/courses/enterprise-typescript-v2/
femCoursePublished: false
femWorkshopUrl: https://frontendmasters.com/workshops/enterprise-typescript-v2/
femWorkshopPublished: true
visibleInTopNav: false
visibleInCourseIndex: false
visibleInTopNav: true
visibleInCourseIndex: true
visibleInCoursePage: true
summary: |
Combine TypeScript and GraphQL's type systems to create full-stack, fully
Expand Down Expand Up @@ -119,7 +119,7 @@ course_groups:
- name: "Enterprise TypeScript"
id: enterprise-typescript
visibleInTopNav: true
visibleInCourseIndex: false
visibleInCourseIndex: true
visibleInCoursePage: true
topNavOrder: 3
courseIndexOrder: 3
Expand Down
21 changes: 18 additions & 3 deletions packages/website/cypress/e2e/course-list/course-list.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ describe('course list page', () => {
});

it('displays multiple courses', () => {
cy.get('.course-summary').should('have.length', 4);
cy.get('.course-summary').should('have.length', 5);
});

it('clicking TS-fundamentals v4 course link visits the course page', () => {
Expand Down Expand Up @@ -69,9 +69,24 @@ describe('course list page', () => {
5,
);
});
it('clicking Enterprise-Scale TypeScript v2 course link visits the course page', () => {
cy.contains('Enterprise-Scale TypeScript').click();
cy.location('href').should(
'include',
'course/enterprise-v2',
);
cy.get('h1').should(
'have.text',
'Enterprise-Scale TypeScript v2',
);
cy.get('.course-article__title').should(
'have.length.at.least',
5,
);
});
it('course top nav has the correct courses', () => {
cy.get('.course-summary:nth-child(2) header h3 a').click();
cy.get('li.course-tab a').should("have.length", 4);
cy.get('li.course-tab a').should("contain.text", "TypeScript Fundamentals v4Intermediate TypeScript v2Making TypeScript StickFull Stack TypeScript");
cy.get('li.course-tab a').should("contain.text", "TypeScript Fundamentals v4Intermediate TypeScript v2Making TypeScript StickEnterprise-Scale TypeScript v2Full Stack TypeScript");
cy.get('li.course-tab a').should("have.length", 5);
});
});
4 changes: 2 additions & 2 deletions packages/website/cypress/e2e/courses/enterprise-typescript-v2.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('enterprise TS v2 course page', () => {
it('title is present', () => {
cy.get('h1').should(
'contain.text',
'Enterprise TypeScript v2',
'Enterprise-Scale TypeScript v2',
);
});
it('summary is present', () => {
Expand All @@ -26,7 +26,7 @@ describe('enterprise TS v2 course page', () => {
it('logo is present', () => {
cy.get('main > header > img')
.should('exist')
.should('have.attr', 'src', '/full-stack-ts.png');
.should('have.attr', 'src', '/enterprise-ts-v2.png');
});
it('clicking on a section works', () => {
cy.get('.course-article__title')
Expand Down
2 changes: 1 addition & 1 deletion packages/website/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@
"lint": "yarn lint:ts && yarn lint:md",
"lint:md": "yarn markdownlint -c ../../.markdownlint.jsonc content",
"lint:ts": "yarn eslint . --ext ts,js,tsx,jsx",
"test": "yarn test:jest && yarn test:cypress",
"test": "yarn test-jest && yarn test-cypress",
"test-jest": "yarn jest",
"test-cypress": "CYPRESS_SUPPORT=y yarn start-server-and-test dev http://localhost:8000 cy:open",
"typecheck": "yarn tsc -P . --noEmit"
Expand Down
Loading