Restore support for Node.js < v12 --experimental-modules mode #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops support for Node.js v12 --experimental-modules mode.
I incorrectly assumed the top entry was the most recent.
|
This looks great; I'm going to (incorrectly) publish this as a non-major change, since I want to revert the breakage I inadvertently caused in a "patch". |
|
Perhaps the change log entry “Major” content could be moved under “Patch” 🤔 |
|
Yes; I'm just rolling those entries up under a single version heading for now, and will invest in clearer headings in the next release. Thanks so much for cleaning up my mess here! I only use native es modules in a couple places, so keeping compatibility there isn't perfectly intuitive for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops support for Node.js v12
--experimental-modulesmode, as discussed here.A few tooling related improvements and fixes are included; see the changelog entry.