Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Encoder.encodeQueryElement public #41

Closed
Entea opened this issue May 2, 2017 · 5 comments
Closed

Make Encoder.encodeQueryElement public #41

Entea opened this issue May 2, 2017 · 5 comments
Assignees

Comments

@Entea
Copy link
Contributor

Entea commented May 2, 2017

Sometimes you need to use io.mikael.urlbuilder.util.Encoder.encodeQueryElement and I extend the Encoder to do that :) Would be great to make it public.

Entea added a commit to Entea/urlbuilder that referenced this issue May 2, 2017
@mikaelhg
Copy link
Owner

mikaelhg commented May 2, 2017

Sometimes you need to use it where? A subclass of Encoder, or some other code which directly uses an Encoder instance?

I'm trying to understand the use case first.

@mikaelhg mikaelhg self-assigned this May 2, 2017
@Entea
Copy link
Contributor Author

Entea commented May 2, 2017

I figured out that Encoder class can be useful by itself, outside of the UrlBuilder class.

In order to use the above mentioned method in my codebase, I need to create a new subclass where I override the method as public.

I thought it would be an improvement to make it public here, to avoid the hassle of creating subclasses of Encoder in my codebase.

@mikaelhg
Copy link
Owner

mikaelhg commented May 3, 2017

OK, sounds sensible.

mikaelhg added a commit that referenced this issue May 5, 2017
@mikaelhg
Copy link
Owner

mikaelhg commented May 5, 2017

Just released 2.0.9 to Maven Central, should include this.

@Entea
Copy link
Contributor Author

Entea commented May 5, 2017

Thanks @mikaelhg !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants