Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RoundedCube should be centered by default #22

Closed
mikosik opened this issue Aug 3, 2016 · 2 comments
Closed

RoundedCube should be centered by default #22

mikosik opened this issue Aug 3, 2016 · 2 comments

Comments

@mikosik
Copy link

mikosik commented Aug 3, 2016

RoundedCube class has private field centered which gets false value during initialization as there's no explicit initialization of that field. The whole functionality that is controlled by that flag field looks to me like copy pasted from Cube class with the only difference that in Cube class it is explicitly initialized with true value. This copy-paste mistake makes it impossible to control centered field in RoundedCube as the only method the changes its value (noCenter()) changes it to false so there's no possibility to change it to true.

@madhephaestus
Copy link
Contributor

This issue is resolved in the branch: https://github.com/NeuronRobotics/JCSG

@miho
Copy link
Owner

miho commented Aug 4, 2016

Thanks for the fix. I'll add the fix to the master branch.

miho added a commit that referenced this issue Aug 4, 2016
miho added a commit that referenced this issue Aug 4, 2016
@miho miho closed this as completed Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants