[DPB]Fixing return code of breakout command on failure (sonic-net#3357)

mihirpat1 · Jun 10, 2024 · c2370f8 · c2370f8
1 parent f96a132
commit c2370f8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/config/main.py b/config/main.py
@@ -249,7 +249,7 @@ def breakout_Ports(cm, delPorts=list(), portJson=dict(), force=False, \
             click.echo("*** Printing dependencies ***")
             for dep in deps:
                 click.echo(dep)
-            sys.exit(0)
+            sys.exit(1)
         else:
             click.echo("[ERROR] Port breakout Failed!!! Opting Out")
             raise click.Abort()

diff --git a/tests/config_dpb_test.py b/tests/config_dpb_test.py
@@ -396,7 +396,7 @@ def test_config_breakout_verbose(self, sonic_db):
             commands["breakout"], ['{}'.format(interface), '{}'.format(newMode), '-v', '-y'], obj=obj)
 
         print(result.exit_code, result.output)
-        assert result.exit_code == 0
+        assert result.exit_code == 1
         assert 'Dependencies Exist.' in result.output
 
         # verbose must be set while creating instance of ConfigMgmt class
@@ -538,7 +538,7 @@ def config_dpb_port8_2x50G_1x100G():
                 commands["breakout"], ['{}'.format(interface), '{}'.format(newMode), '-v','-y'], obj=obj)
 
             print(result.exit_code, result.output)
-            assert result.exit_code == 0
+            assert result.exit_code == 1
             assert 'Dependencies Exist.' in result.output
             assert 'Printing dependencies' in result.output
             assert 'NO-NSW-PACL-V4' in result.output