Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some icons for Angular files #244

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dimentoree
Copy link
Contributor

Add icons for:

  • directive files
  • module files
  • guard files
  • pipe files

Also add icon support for service.dart and component.dart files

@miguelsolorio
Copy link
Owner

@dimentoree thanks for the PR, can you add a screenshot of these icons from the extension? Thanks!

@dimentoree
Copy link
Contributor Author

dimentoree commented Sep 12, 2024

@dimentoree thanks for the PR, can you add a screenshot of these icons from the extension? Thanks!

@miguelsolorio, can you explain how to correctly add the display of new icons for files in the VS code, because I can’t seem to get it right? And then attaching screenshots of icons from Figma is so-so. Maybe I need to additionally install some extension or set some settings for vs code

@miguelsolorio
Copy link
Owner

miguelsolorio commented Sep 18, 2024

@dimentoree I'm not sure I understand your question. Are you asking how to add new file icons? You've created PRs before so this question is a little confusing.

@dimentoree
Copy link
Contributor Author

dimentoree commented Oct 7, 2024

@dimentoree I'm not sure I understand your question. Are you asking how to add new file icons? You've created PRs before so this question is a little confusing.

@miguelsolorio, hello! Sorry for the long absence. I figured out my problem, so the issue is resolved. I am attaching a screenshot
изображение

@miguelsolorio miguelsolorio self-assigned this Oct 24, 2024
@miguelsolorio miguelsolorio added icon request Request for a new icon and removed response needed labels Oct 24, 2024
@miguelsolorio miguelsolorio added this to the 0.0.21 milestone Oct 24, 2024
@miguelsolorio miguelsolorio merged commit 7aa968a into miguelsolorio:main Oct 24, 2024
1 check passed
@dimentoree dimentoree deleted the add-angular-icons branch October 30, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
icon request Request for a new icon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants