paper menu, paper select and paper autocomplete #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into paper-menu
miguelcobain
changed the title
fixed issue with ember 2.7+ select-options
brendanoh
reviewed
Oct 8, 2016
| default: | ||
| break; | ||
| scrollTo(option /*, e */) { | ||
| if (!self.document || !option) { |
brendanoh
reviewed
Oct 8, 2016
| } | ||
| }, | ||
| let publicAPI = this.get('publicAPI'); | ||
| let optionsList = self.document.getElementById(`ember-power-select-options-${publicAPI.uniqueId}`); |
There was a problem hiding this comment.
The global self is a shortcut to window.self. They are both the very same object.
There was a problem hiding this comment.
There was a problem hiding this comment.
Understood. When I pointed my existing project to the latest commit f780b54 I got those 2 lines as lint errors.
Use ember-power-select 1.0.0-beta.23's new `defaultHighlighted` option to override its default highlighting (on open and filter/search) to match AM's behaviour
|
@miguelcobain autocomplete is ready to be merged. The scroll mask and searchTextChanged I'm working on can wait. Let's merge it finally - keep the warning sign in demo app - some autocomplete API might change slightly |
* kludge to fix glimmer2 support pending interaction from ember team * fixed issue with ember 2.7+ select-options * API change for autocomplete and support for tracking search text * fixed floating label issue * added readonly helper to searchText
receives a focus.
|
paper-select remaining todos:
|
39 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.