Autocomplete API change #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should be ready now. |
xomaczar
reviewed
Oct 14, 2016
| @@ -40,6 +40,7 @@ | |||
| onKeydown=(action "onKeydown") | |||
| searchEnabled=(readonly searchEnabled) | |||
| searchField=(readonly searchField) | |||
| searchText=searchText | |||
There was a problem hiding this comment.
Can we be explicit here and show that's searchText is one way with readonly helper
There was a problem hiding this comment.
just added commit to fix this, should be good now.
| @@ -66,11 +74,14 @@ export default Component.extend({ | |||
| }, | |||
|
|
|||
| handleInputLocal(e) { | |||
| // If something is already selected when the user types, it should clear selection | |||
| if (this.get('selected')) { | |||
| this.get('select').actions.select(null); | |||
There was a problem hiding this comment.
Does it auto search or we need to call actions.search
There was a problem hiding this comment.
the onInput fires and calls search automatically.
|
LGTM - let's merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
search text should now be tracked and initializeable. Typing after something is already selected clears selection.