Trying to address paper-tabs issues #1048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
edit: worked around by not calling 'fixOffset' in didRender |
1 similar comment
|
edit: worked around by not calling 'fixOffset' in didRender |
panthony
changed the title
Doing this avoid, on render where the selected tab is NOT the first tab, to have the inkBar quickly starting from offset 0 to the actual selected tab.
By defaults, assume this is true.
This is unnecessary because we already have the hook in paper-tabs that: - is always called after one of the tab didRender - calls 'updateDimensions' on all of its children
As it will be done directly after in didRender
Because didRender will be called and will call this method too.
Because when navigating there is a render without any selected tab
Because we pass 'selected' to each of them, updating the selected tab will invalidate all the 'isSelected' property which will trigger an validation of _selectedTab (thus observer callback) for each nested tab
Only do it in two occasions: - first render - selected tab was updated Otherwise it will prevent user's pagination as the selected tab will become partially hidden.
panthony
force-pushed
the
fix/paper-tabs
branch
from
5cf4149 to
2476826
Compare
|
@panthony I pulled in your changes into a project and it resolved an issue for me where the next/previous buttons were disabled when they shouldn't have been. I'll do some more testing, but I see no issues so far. |
|
@panthony sorry for the delay, I also pulled your tag and it works, gonna keep testing my use cases, and will let you know, thanks for the effort |
|
I spotted this PR after submitting my own to fix the pagination issues. I can confirm that this fixes #1063 for me, as well as the other issues listed in the OP. |
|
Thanks a lot @panthony. Sorry for taking so long to review. This looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully:
I'm trying to take a fresh start at paper tabs offsets handling as they are may issues at the moment.
If they are things that I'm missing feel free to tell me.
Amongs the hopefully fixed issues:
Issues yet to be fixed:
edit:
To correct this 'fixOffset' issue that breaks the pagination I now call it in only 2 cases:
I'm not calling it anymore in 'didRender' which means that if the tab's label is updated while selected it might become partially hidden but this is way WAY minor IMO.
edit²:
Unfortunately I do not have time for this right away but I think we should add some tests with a wrapper around "paper-tabs" with a small max width, to ensure that we can still paginate around.