Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

paper-tabs: arrows to scroll on overflowing tabs are always disabled #1063

Closed
bjornharrtell opened this issue Feb 10, 2019 · 7 comments
Closed

paper-tabs: arrows to scroll on overflowing tabs are always disabled #1063

bjornharrtell opened this issue Feb 10, 2019 · 7 comments

Comments

@bjornharrtell
Copy link
Contributor

Bisected to 23073e8
@saivarunr
Copy link

Same issue unable to scroll left or right.

@pauln
Copy link
Contributor

pauln commented Feb 20, 2019

Changing tab seems to trigger something which enables the arrow buttons, as they start to work once you've changed to a different tab.

@pauln
Copy link
Contributor

pauln commented Feb 20, 2019

Correction/update: Simply being on any tab that's not the first is sufficient to activate the buttons. If selected is set to a tab other than the first, even as its initial state, the arrow buttons seem to work fine.

pauln added a commit to pauln/ember-paper that referenced this issue Feb 20, 2019
@pauln
Fix tab pagination controls
04a0606 
Fixes adopted-ember-addons#1063 by stopping currentOffset from being set to undefined, and preventing fixOffsetIfNeeded() from being run on every render.
@pauln pauln mentioned this issue Feb 21, 2019
Closed
@pauln
Copy link
Contributor

pauln commented Feb 21, 2019

It turned out to be a bit more complex than that, though the fix seems to be pretty simple. See PR #1068 for more detail.

@pauln pauln mentioned this issue Feb 21, 2019
Merged
@panthony
Copy link
Contributor

@bjornharrtell Do you still reproduce this issue with the latest release?

@bjornharrtell
Copy link
Contributor Author

@panthony looks like it works great now, at least what I can see in limited testing. Much appreciated, thanks!

@miguelcobain
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tab pagination controls pauln/ember-paper
5 participants
@bjornharrtell @panthony @pauln @miguelcobain @saivarunr