pin @ember/test-helpers to 2.7.0 #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SergeAstapov
force-pushed
the
pin-ember-test-helpers
branch
from
db1e0ae to
fa344ae
Compare
SergeAstapov
force-pushed
the
pin-ember-test-helpers
branch
from
24f3b03 to
0d33945
Compare
SergeAstapov
changed the title
|
this fixes CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR emberjs/ember-test-helpers#1211 (released in v2.8.0)
made
ember-sourcea peerDependency of@ember/test-helpers.In case of
ember-keyboardmonorepo setup, packageember-sourcedoes not get hoisted and stay in the
test-app/node_modulesbut at the same time@ember/test-helpersgets hoisted as well as some another version ofember-source.By pinning
@ember/test-helperspackage we avoid this issue.