Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added esp8266 support #235

Closed
wants to merge 1 commit into from
Closed

added esp8266 support #235

wants to merge 1 commit into from

Conversation

konsgn
Copy link

@konsgn konsgn commented Aug 29, 2016

It seems to work for the esp8266 as well as the teensy2.0, don't have any standard arduinos to test, but it is basically pulled from a working adafruit library (st7735 driver).

@Rotzbua Rotzbua added the need_feedback ↩️ awaiting feedback from people label Aug 31, 2016
@Rotzbua
Copy link
Collaborator

Rotzbua commented Aug 31, 2016

This library already works with the esp8266 compiled with the Adruino IDE plugin https://github.com/esp8266/Arduino .
I think your changes were only needed if you do not use the Arduino IDE. So I would refuse this pr, because the main target is the Arduino IDE.
But should I add a link to your patch in the readme, for ppl who do not use the IDE? @konsgn

@Rotzbua Rotzbua added the invalid 🚫 not relevant for the library label Aug 31, 2016
@konsgn
Copy link
Author

konsgn commented Aug 31, 2016

Yup, Sorry about that, I think I was having a slightly different error that was causing it not to work for esp8266.

Science!


From: Rotzbua notifications@github.com
Sent: Wednesday, August 31, 2016 11:56:28 AM
To: miguelbalboa/rfid
Cc: konsgn; Mention
Subject: Re: [miguelbalboa/rfid] added esp8266 support (#235)

This library already works with the esp8266 compiled with the Adruino IDE plugin https://github.com/esp8266/Arduino .
I think your changes were only needed if you do not use the Arduino IDE. So I would refuse this pr, because the main target is the Arduino IDE.
But should I add a link to your patch in the readme, for ppl who do not use the IDE? @konsgnhttps://github.com/konsgn

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/235#issuecomment-243810828, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE-UYrGTp3NKHwZwk8dOswPPWs9pdypqks5qlaQsgaJpZM4JvoCD.

@konsgn
Copy link
Author

konsgn commented Aug 31, 2016

Don't bother with the patch, Let my try the original again and figure it out.

Science!


From: Konstantin Avdashchenko konsgn@hotmail.com
Sent: Wednesday, August 31, 2016 12:24:44 PM
To: miguelbalboa/rfid; miguelbalboa/rfid
Cc: Mention
Subject: Re: [miguelbalboa/rfid] added esp8266 support (#235)

Yup, Sorry about that, I think I was having a slightly different error that was causing it not to work for esp8266.

Science!


From: Rotzbua notifications@github.com
Sent: Wednesday, August 31, 2016 11:56:28 AM
To: miguelbalboa/rfid
Cc: konsgn; Mention
Subject: Re: [miguelbalboa/rfid] added esp8266 support (#235)

This library already works with the esp8266 compiled with the Adruino IDE plugin https://github.com/esp8266/Arduino .
I think your changes were only needed if you do not use the Arduino IDE. So I would refuse this pr, because the main target is the Arduino IDE.
But should I add a link to your patch in the readme, for ppl who do not use the IDE? @konsgnhttps://github.com/konsgn

You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHubhttps://github.com//pull/235#issuecomment-243810828, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AE-UYrGTp3NKHwZwk8dOswPPWs9pdypqks5qlaQsgaJpZM4JvoCD.

@mlinaje
Copy link

mlinaje commented Apr 26, 2018

by the way and due to the relation between esp8266 and esp32, I must say the library works with esp32 too: https://www.youtube.com/watch?v=j2vT5eBpp4Q

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid 🚫 not relevant for the library need_feedback ↩️ awaiting feedback from people
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants