-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update peer dependency eslint-plugin-n to v16 #1143
Conversation
New dependency changes detected. Learn more about Socket for GitHub ↗︎ 👍 No new dependency issues detected in pull request Bot CommandsTo ignore an alert, reply with a comment starting with Pull request alert summary
📊 Modified Dependency Overview:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's required to first update eslint-config-standard
to the new version 17.1.0
@@ -60,7 +60,7 @@ | |||
"@typescript-eslint/eslint-plugin": "^5.43.0", | |||
"eslint": "^8.0.1", | |||
"eslint-plugin-import": "^2.25.2", | |||
"eslint-plugin-n": "^15.0.0", | |||
"eslint-plugin-n": "^16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"eslint-plugin-n": "^16.0.0", | |
"eslint-plugin-n": "^15.0.0 || ^16.0.0", |
CI: Own peerDependencies include those of eslint-config-standard
peerDependencies from eslint-config-standard: package.json
Thank you. We'll take a look at this. Highest priority is currently #1149. |
Thank you for this, @CCFenner. This bump should go together with bumping esling-config-standard. In fact, I wonder why no tests failed... |
Thank you for you effort, @CCFenner . This took some more work, so we did this ourselves. Enjoy. |
What is the purpose of this pull request? (put an "X" next to item)
[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:
What changes did you make? (Give an overview)
update peer dependency
Which issue (if any) does this pull request address?
#1142
#1135
Is there anything you'd like reviewers to focus on?