Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependency eslint-plugin-n to v16 #1143

Closed
wants to merge 2 commits into from

Conversation

CCFenner
Copy link

@CCFenner CCFenner commented May 23, 2023

What is the purpose of this pull request? (put an "X" next to item)

[ ] Documentation update
[x] Bug fix
[ ] New feature
[ ] Other, please explain:

What changes did you make? (Give an overview)
update peer dependency

Which issue (if any) does this pull request address?
#1142
#1135

Is there anything you'd like reviewers to focus on?

@welcome
Copy link

welcome bot commented May 23, 2023

🙌 Thanks for opening this pull request! You're awesome.

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
eslint-plugin-n@16.0.0 filesystem +1 weiran.zsd

Copy link

@falsepopsky falsepopsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's required to first update eslint-config-standard to the new version 17.1.0

@@ -60,7 +60,7 @@
"@typescript-eslint/eslint-plugin": "^5.43.0",
"eslint": "^8.0.1",
"eslint-plugin-import": "^2.25.2",
"eslint-plugin-n": "^15.0.0",
"eslint-plugin-n": "^16.0.0",
Copy link

@falsepopsky falsepopsky May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"eslint-plugin-n": "^16.0.0",
"eslint-plugin-n": "^15.0.0 || ^16.0.0",

CI: Own peerDependencies include those of eslint-config-standard
peerDependencies from eslint-config-standard: package.json

@mightyiam
Copy link
Owner

Thank you. We'll take a look at this. Highest priority is currently #1149.

@mightyiam
Copy link
Owner

Thank you for this, @CCFenner. This bump should go together with bumping esling-config-standard. In fact, I wonder why no tests failed...

@mightyiam
Copy link
Owner

Thank you for you effort, @CCFenner . This took some more work, so we did this ourselves. Enjoy.

@mightyiam mightyiam closed this Jul 15, 2023
@CCFenner CCFenner deleted the patch-1 branch August 2, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants