Skip to content

Commit

Permalink
build: shared commitlint config
Browse files Browse the repository at this point in the history
Co-authored-by: Rostislav Simonik <rostislav.simonik@technologystudio.sk>
  • Loading branch information
mightyiam and rostislav-simonik committed Jul 29, 2023
1 parent 3bbc255 commit bdd6e2d
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 6 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,16 +43,16 @@ jobs:
- uses: actions/checkout@v3
with:
fetch-depth: 0 # for commit linting
# Hiding tsconfig.json to workaround
# https://github.com/conventional-changelog/commitlint/issues/3256
- run: mv tsconfig.json tsconfig.json.nope
- uses: wagoid/commitlint-github-action@v5
- run: mv tsconfig.json.nope tsconfig.json
- uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- run: npm --global install npm@latest
- run: npm ci
# Hiding tsconfig.json to workaround
# https://github.com/conventional-changelog/commitlint/issues/3256
- run: mv tsconfig.json tsconfig.json.nope
- uses: wagoid/commitlint-github-action@v5
- run: mv tsconfig.json.nope tsconfig.json
- run: npm test
get-supported-node-versions:
runs-on: ubuntu-latest
Expand Down
2 changes: 1 addition & 1 deletion commitlint.config.js
Original file line number Diff line number Diff line change
@@ -1 +1 @@
module.exports = { extends: ['@commitlint/config-conventional'] }
module.exports = { extends: ['standard'] }
7 changes: 7 additions & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@
"@typescript-eslint/eslint-plugin": "5.62.0",
"@ungap/structured-clone": "1.2.0",
"ava": "5.3.1",
"commitlint-config-standard": "github:standard/commitlint-config-standard",
"editorconfig-checker": "5.1.1",
"eslint": "8.46.0",
"eslint-plugin-import": "2.28.0",
Expand Down
1 change: 1 addition & 0 deletions src/index.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,7 @@ test('Dependencies range types', async (t) => {
`Peer dependency \`@typescript-eslint/eslint-plugin: ${typescriptEslintPluginValue}\` is a single \`^\` range.`
)
for (const [name, spec] of Object.entries(ourDevDeps)) {
if (spec.startsWith('github:')) continue
const range = name.startsWith(`${typescriptEslintBottom}/`) ? extractVersionSpec(spec) : spec
t.true(isPinnedRange(range), `Dev dependency \`${name}: ${spec}\` is pinned`)
}
Expand Down

0 comments on commit bdd6e2d

Please sign in to comment.