Remove 'unkown props' from DOM elements; fixes #16 #19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an interesting problem to 'solve', this was the cleanest and most transparent method I could think of. It touches a bunch of files, though.
Another option was just to
const {invalidProps, ...everythingElse} = this.props
and then<span ...everythingElse>
in a one liner. But it would produce a lot of unusedconst
s and would just get pretty messy.Let me know your thoughts!