change t_withdrawals to order by index #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santi1234567
deleted the
fix/t_withdrawals-contains-only-one-withdrawal-per-slot
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
During the migration process of V3 from postgres to clickhouse, the t_withdrawals table started only storing one withdrawal per slot (there should be a maximum of 16, which is the case for most slots).
Description
Changed the order by column from the
t_withdrawalsto usef_indexsince usingf_slotonly allows one withdrawal per slot (becauset_withdrawalsuses theReplacingMergeTreeengine).f_indexis unique to each withdrawal and makes much more sense.Proof of Success
Closes #122