Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcut conflict #279

Closed
sojey opened this issue Mar 20, 2020 · 6 comments
Closed

Shortcut conflict #279

sojey opened this issue Mar 20, 2020 · 6 comments

Comments

@sojey
Copy link

sojey commented Mar 20, 2020

ver. 3.17.0 and older verion.
The menu bar has two completely different functions, using the same shortcut !
ctrl+w
File - close & window - close
When I closed the file without closing the software, it puzzled me, and then I discovered that it was a shortcut conflict.

@mifi
Copy link
Owner

mifi commented Mar 23, 2020

Is it on windows? Can you show me a screenshot? On Mac there is no conflict. Only File -> Close is cmd+w, which is how I intended it, because it makes no sense to close only the window iwthout closing the app

@sojey
Copy link
Author

sojey commented Mar 24, 2020

Is it on windows? Can you show me a screenshot? On Mac there is no conflict. Only File -> Close is cmd+w, which is how I intended it, because it makes no sense to close only the window iwthout closing the app

yes, windows 10 x64, but I can't upload pic in here, if you have windows 10, you can follow the menu that I typed. My english is not good, hope you can understand.

mifi added a commit that referenced this issue Mar 26, 2020
@mifi
Copy link
Owner

mifi commented Mar 26, 2020

This is now fixed in newest version

@mifi mifi closed this as completed Mar 26, 2020
@mattack1
Copy link

But it does make sense on Mac.. I can't bring up the About window for example, and close it with cmd-W. The menu flickers, but nothing happens.

Also, though I generally dislike this kind of app, you could make it so closing the window quits the app. Some single-window-apps use that UI.. e.g. even System Preferences.

@mifi
Copy link
Owner

mifi commented Mar 30, 2020

I agree that cmd-W should close windows, but since there is only one other window in the app (the about window), i don't wanna do anything about that now. Also I don't want people to accidently exit the app if they cmd+w twice. It seems like Mac doesn't have the close menu under window

@mattack1
Copy link

I totally agree that it's a low priority item, but not having cmd-W work for even 'just' the About window is yet another thing that makes the app's UI not be consistent with the Apple GUI. (But e.g. I use a Java app, kmttg, that's totally weird too..)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants