Call Finalize on Module destroy #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miekg
reviewed
Nov 12, 2022
p11/module.go
Outdated
| break | ||
| } | ||
| } | ||
| if path == "" { |
There was a problem hiding this comment.
is it really needed to return an error, or just make this a noop? With the later approach we don't need to change the method's signature
There was a problem hiding this comment.
I believe it works without it too. I've reverted the API change now 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using softhsm in some tests, I ran into issues while re-using the same pkcs11 context. Calling
module.Destroytogether with these fixes allow me to use the p11 module (instead of going all in on the raw pkcs11 interface).Returns
errorfrom theModule.Destroyin p11. This is an API change. I can remove this if wanted.Calls
ctx.Finalizebefore callingctx.DestroyinModule.DestroyThis allow a more graceful unloading of modules. I suspect there are multiple reasons why you didn't do this before? At least removing the loaded module from the map should improve a lot.