Correct TODO in udp_windows.go #1433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These TODOs were not correct as x/net/ipv4 and x/net/ipv6 still don't have Windows support.
|
Hopefully you don't mind me asking here, but it's the most recent issue/PR about Windows. Would this be an explanation for why failures to connect to a DNS server takes significantly longer on Windows? We're investigating the tests in caddyserver/certmagic#228 (comment) and the ones that use intentionally incorrect resolver addresses (localhost with a non-standard port) takes until the configured timeout to return, whereas on other platforms it fails fast. We're using |
|
@francislavoie I don't believe so as this should only really impact sending packets and making sure they go out the right interface. I'd be surprised if it could cause that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These TODOs were not correct as x/net/ipv4 and x/net/ipv6 still don't have Windows support.
Updates #738
Updates #765
Updates coredns/coredns#2138
See golang/go#7175
See golang/go#7174