dns.ParseZone() parsing error leading to nil pointer dereference

[tr3ee]

What did I do?

PoC.go

package main

import (
	"fmt"
	"strings"

	"github.com/miekg/dns"
)

func main() {
	r := strings.NewReader(` Ta 0 0 0`)
	for x := range dns.ParseZone(r, "", "") {
		if x.Error != nil {
			fmt.Println(x.Error)
		} else if x == nil {
			// This should never be reached
			fmt.Println("x == NIL")
		} else {
			// Do something with x.RR
			fmt.Println(x.RR.String())
		}
	}
	return
}

What happened?

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x65a762]

goroutine 1 [running]:
main.main()
	/path/to/gopath/src/fuzz/dns/worker/main.go:20 +0x122
exit status 2

[miekg]

You're fuzzing the text parser? If so, good. Are you able to send a PR/fix for this? [ Quoting <notifications@github.com> in "[miekg/dns] dns.ParseZone() parsing..." ]

### What did I do? PoC.go ```golang package main import ( "fmt" "strings" "github.com/miekg/dns" ) func main() { r := strings.NewReader(` Ta 0 0 0`) for x := range dns.ParseZone(r, "", "") { if x.Error != nil { fmt.Println(x.Error) } else if x == nil { // This should never be reached fmt.Println("x == NIL") } else { // Do something with x.RR fmt.Println(x.RR.String()) } } return } ``` ### What happened? ``` panic: runtime error: invalid memory address or nil pointer dereference [signal SIGSEGV: segmentation violation code=0x1 addr=0x20 pc=0x65a762] goroutine 1 [running]: main.main() /path/to/gopath/src/fuzz/dns/worker/main.go:20 +0x122 exit status 2 ``` -- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: #742

/Miek

…

-- Miek Gieben

[tr3ee]

@miekg
I will take a look this tomorrow or a few day : )

[miekg]

[ Quoting <notifications@github.com> in "Re: [miekg/dns] dns.ParseZone() par..." ]

@miekg I will take a look this tomorrow or a few day : )

thanks!

[tr3ee]

@miekg
A PR #745 has been sent, please review it

[tmthrgd]

#745 didn't have the magic commit message that would have closed this issue.