-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Question: PreventDefault in touchmove event #31
Comments
@SinnerAir Sorry for no reply the whole time. What do you mean by scale with a gesture?
via https://developpaper.com/implementation-of-html5-touch-events-touchstart-touchmove-and-touchend/ |
scale with two fingers holding, and moving away from each other? |
I just tested it, removing that line does not break navigation on mobile, but allows to zoom image using 2 fingers on mobile. |
It should work on next version. |
I can't get this "2-finger-zoom" zoom working on my live site (Android and Safari). Image just moves as of switch the slides. @viliusle Can you confirm this is working? I could test in |
I tested it again with latest develop branch code on android device, chrome browser. Zoom with 2 fingers works. p.s. I was able to zoom actual page too, but even i tap on image and modal window is activated, I still can zoom it, but I see that page itself zooms too in background. So it is not only image zoom, but zoom everything. |
The code contains such a line https://github.com/rqrauhvmra/tobii/blob/ac432322c09dc30eba853a17b252250ba87ed453/src/js/tobii.js#L1234
Can you find out what it is for? Because it does not provide the ability to scale with a gesture.
The text was updated successfully, but these errors were encountered: