Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close button and counter float on the picture #23

Closed
SinnerAir opened this issue May 15, 2020 · 6 comments
Closed

Close button and counter float on the picture #23

SinnerAir opened this issue May 15, 2020 · 6 comments
Labels
question Further information is requested
Milestone

Comments

@SinnerAir
Copy link

SinnerAir commented May 15, 2020

Close button and counter float on the picture in mobile if the picture is stretched in height.

22ea2ced31

I fixed it like this:

.tobii__slider {
    top: 5em;
}

[data-type] {
    height: 100%;
    max-height: 100%;
    display: flex;
    align-items: center;
}

    [data-type] > figure {
        max-height: 100%;
    } 
@viliusle
Copy link
Collaborator

Another option is to let it overlap, but adapt styles in a way, that overlaping would not be a problem.
Screenshot 2021-06-23 at 17 23 21

@midzer midzer added the question Further information is requested label Jul 2, 2021
@midzer
Copy link
Owner

midzer commented Jul 2, 2021

I'm up for both.
Let's see what others think about this... cc @ocean90

@ocean90
Copy link
Collaborator

ocean90 commented Jul 5, 2021

I'd probably also add a safe area for the top bar and on smaller screens we may want to reduce the size of the button to 44x44px which is the recommended minimum tappable area for buttons.

Edit: The gallery at the bottom of this article does something similar.

@viliusle
Copy link
Collaborator

viliusle commented Jul 6, 2021

33
Preview how it can look in small screen.

viliusle added a commit that referenced this issue Jul 6, 2021
@midzer midzer added this to the v2.3.0 milestone Jul 29, 2021
@midzer
Copy link
Owner

midzer commented Jul 29, 2021

Looking good.
Let's see how it works out live!

@viliusle
Copy link
Collaborator

viliusle commented Jul 29, 2021

Another version preview:

  • max height - 100%
  • max-width - 100%
  • top line has black color with opacity 0.5
  • works well on mobile / small screen, because image can take literally 100% of screen space.

v3

p.s. image above is not at 100%!

@midzer midzer closed this as completed Aug 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

4 participants